prevent attachment column updates when importing budibase templates #15000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to import apps from templates while preserving the attachment data from those template dbs.
updateAttachmentColumns
is great when importing an app with attachments from a file, but wrecks the attachment data in our templates which is always pointing to a public s3 bucket rather than the instance's own object storagefor example, an attachment in my template app db:
gets completely stripped out by the above function. I've added in a flag to prevent it from running when we're importing from a template rather than a file (i.e. when
template.key
has a value)Launchcontrol
fix for attachments in budibase templates