Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions modal and icon UI update #14856

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

joebudi
Copy link
Contributor

@joebudi joebudi commented Oct 23, 2024

Description

I updated the UI in several places, primarily the Automations section, to improve the design and experience.

I made styling changes that were not attached to our design system - specifically, the yellow and indigo within automations. These colors make the UI "pop." Happy to discuss this in more detail.

@deanhannigan I removed the left and right arrows on branches—I don't think they're needed. We can add them back if necessary.

Screenshots

Automations

Darkest
CleanShot 2024-10-23 at 15 40 49@2x

Light
CleanShot 2024-10-23 at 15 43 03@2x

New Automation Modal

  • removed unnecessary text
  • Improved card spacing
  • Added background colors

Darkest
CleanShot 2024-10-23 at 15 52 54@2x

Light
CleanShot 2024-10-23 at 15 44 14@2x

New Automation Action Modal

  • spacing and layout changed - 3 columns
  • added backgrounds to icons
  • changed Icon colors
  • Improved font size

It would be beneficial to introduce a third category - Logic to this modal. I would also change Condition to "Continue If"

Darkest
Uploading CleanShot 2024-10-23 at 15.54.59@2x.png…

Light
CleanShot 2024-10-23 at 15 44 57@2x

New Automation Card

  • Card width reduced to accommodate more cards
  • Single title - removed label.
  • Icon background color added for trigger and action
  • removed left and right options branching
  • Label and fields split across two rows
  • Spacing improved
  • Colors fixed on light mode.

Darkest
CleanShot 2024-10-23 at 15 48 03@2x

Tag

Darkest
CleanShot 2024-10-23 at 15 57 36@2x

Light

CTA tag
CleanShot 2024-10-23 at 15 45 56@2x

Non-CTA tag
CleanShot 2024-10-23 at 15 46 19@2x

Alignment issue

CleanShot 2024-10-23 at 15 58 28@2x

Add a small description in layman's terms of what this PR achieves. This will be used in the release notes.

I believe it improves the overall UX/UI

Modal size and layout
- increase the size of the modal header (and others)
- increased modal size
- changed the grid to 3 columns rather than 2
- increase the size of the label text
- moved actions to the top and apps to the bottom

Items:
- increased the size of the automation labels
- added a background color to action icons
- increase the size of all icons
- changed the color of action icons to gray 900

item cards:
- updated the spacing within the item cards
- changed border color of items

disabled items:
- added opacity to the disabled actions
- added background to trigger - orange
- added background color to actions - indigo
- changed backend log icon
- added static values for trigger icon and action icons
- added a background to external app actions
- changed layout of labels + fields
- resized automation cards
- removed automation label. Made Automation title more prominent.
- creation automation modal layout changed
- removed label for name field
- removed help text
- removed warning
- added background to icons
- changed item size
- added placeholder to name input
- improved inline alert title spacing
- added a background color to the modal component - it was grey on light
- changed static color of triggers - yellow
-
- the grey on grey has bugged me for eternity. I also like how it looks in darkest mode too - the contrast is nice.
- updated tag component to make it stand out more and add more color to the UI. Most of the time, the tag component is used to inform the user if a feature is paid. This work emphasizes this.
@joebudi joebudi requested a review from a team as a code owner October 23, 2024 16:12
@joebudi joebudi requested review from adrinr and removed request for a team October 23, 2024 16:12
Copy link

qa-wolf bot commented Oct 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@aptkingston aptkingston changed the base branch from master to v3-ui October 24, 2024 06:27
@aptkingston aptkingston changed the base branch from v3-ui to feature/automation-branching-ux October 24, 2024 06:27
@aptkingston
Copy link
Member

aptkingston commented Oct 25, 2024

I think these changes look really good Joe 👌

Only thing I spotted is that the looping icon needs updated to match the new icon styles:
image

I think the reduction in text here is welcome:
image
But do you reckon we could just remove it in general? We could put a warning icon up beside the activated toggle if the app is unpublished or something. I just think having this big warning in general looks not great and is very front and center.

I reckon we should also bring back the arrows for branches, because there are definitely cases where you'd want to reorder your branches, and the only option without that is to delete and recreate your conditions on every branch which would be quite tedious.

I don't mind the width reduction of the steps, but I don't like that this is now on 2 lines:
image
We should reduce the text so it fits on one line or increase the width again slightly. Not related to your changes, but this text also doesn't need to be so prominent and white. Maybe a size reduction and a darker shade of grey could work.

@joebudi
Copy link
Contributor Author

joebudi commented Oct 25, 2024

I initially removed the warning from the new automation model. @PClmnt felt it was needed. I feel that if it is needed, this is not the place to show it - considering it's the first thing people see, and the action (publish) is the last thing users do.

Good spot with the looping icon. I wanted to create a 3rd category - Logic or something and provide a different color for them. If I was to make another change - I would change the shape of the trigger icon to a hexagon or something to make it really stand out - or the budibase logo arrow.

Branching arrows
There's a lot of power in those arrows - I don't like that they come before the warning - they look like a UI action for reordering branches. I think people will click them without reading the warning - at the bottom of the branch.
I would add a label above the branch to say something similar to the way Hubspot does it:
CleanShot 2024-10-25 at 09 49 57@2x

  • first check this branch...
  • then check branch 2 criteria...
  • then check branch 3 criteria ...
  • If none of the criteria are met, go here: (default "Conditions not met" branch added to every branch action)

CleanShot 2024-10-25 at 09 55 32@2x

Also... if we do add back the arrows, I'd probably add a more icon and place the delete, left, and right functionality in there.

@ben-budibase
Copy link

@joebudi @aptkingston

https://www.figma.com/design/LZJRE6DsiGGCEjB7aqFYGx/Automations?node-id=704-5340&t=0pJ9dqYNWcX9ZPjL-1
Screenshot 2024-10-25 at 14 28 42

Joe and had a call earlier with version iterations on the automation branching. As you'll see I've amended the design to include Joe's latest additions as well as some of my own. These include having 'First check this branch', then 'then check this branch' at the top of the nodes. In addition, we've removed the info text and placed the branch movement buttons in a submenu with contextual labels, that way the user understands what they mean.

Let me know your thoughts!

- updated looping icon (cyan + black)
- updated looping label type - to p
- removed label margin
- spacing (between delete and chevron icons) was different between looping and actions
Base automatically changed from feature/automation-branching-ux to master November 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants