Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 856: refactoring of how filenames are chosen for Detailed Summary #894

Merged
merged 18 commits into from
Nov 4, 2024
Merged

Issue 856: refactoring of how filenames are chosen for Detailed Summary #894

merged 18 commits into from
Nov 4, 2024

Commits on Oct 8, 2024

  1. refactor how filenames are chosen

    @artoonie
    artoonie committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8e3da5e View commit details
    Browse the repository at this point in the history

  2. move files to new recommended name

    @artoonie
    artoonie committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b1c54a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. rename ResultFile to ResultTypeAndSlice, and CVR_CDF to CDF_CVR

    @artoonie
    artoonie committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    b9dacb6 View commit details
    Browse the repository at this point in the history

  2. address additional PR comments

    @artoonie
    artoonie committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    43dae82 View commit details
    Browse the repository at this point in the history

  3. rename files: CVR_CDF to CDF_CVR

    @artoonie
    artoonie committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    47bcf7e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. refator to make explicit the difference between a results file (what … 

    …we previously referred to as the summary files) and an output file (the results files plus rctab_cvr and cdf_cvr)
    @yezr
    yezr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b7f6708 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. fix comment

    @yezr
    yezr committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    36ee354 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. refactor how filenames are chosen

    @artoonie
    artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5780b40 View commit details
    Browse the repository at this point in the history

  2. move files to new recommended name

    @artoonie
    artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4b9363d View commit details
    Browse the repository at this point in the history

  3. rename ResultFile to ResultTypeAndSlice, and CVR_CDF to CDF_CVR

    @artoonie
    artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d759708 View commit details
    Browse the repository at this point in the history

  4. address additional PR comments

    @artoonie
    artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2b0549b View commit details
    Browse the repository at this point in the history

  5. rename files: CVR_CDF to CDF_CVR

    @artoonie
    artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    430fc24 View commit details
    Browse the repository at this point in the history

  6. refator to make explicit the difference between a results file (what … 

    …we previously referred to as the summary files) and an output file (the results files plus rctab_cvr and cdf_cvr)
    @yezr @artoonie
    yezr authored and artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e3090be View commit details
    Browse the repository at this point in the history

  7. fix comment

    @yezr @artoonie
    yezr authored and artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    26db423 View commit details
    Browse the repository at this point in the history

  8. PR comments addressed and tests fixed

    @artoonie
    artoonie committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    33bd309 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge remote-tracking branch 'origin/feature/issue-856_summary-extend… 

    …ed-refactor' into feature/issue-856_summary-extended-refactor

# Conflicts:
#	src/main/java/network/brightspots/rcv/OutputWriter.java
#	src/test/java/network/brightspots/rcv/TabulatorTests.java
    @yezr
    yezr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    77624ac View commit details
    Browse the repository at this point in the history

  2. add warning message for sanitized slice filename collision

    @yezr
    yezr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    634b585 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. fix logging message location

    @artoonie
    artoonie committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    24ff1f6 View commit details
    Browse the repository at this point in the history