Override next() and endOfJson() methods because JIT C2 keeps de-optimizing them #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donavdey
changed the title
|
Note These results are affected by shared workloads on GitHub runners. Use the results only to detect possible regressions, but always rerun on more stable machine before making any conclusions! Benchmark results (pull-request, 5aa6566)Benchmark results (master, 9f0690f) |
donavdey
force-pushed
the
buffered-masking-state
branch
from
de958c0
to
5aa6566
Compare
|
gavlyukovskiy
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gavlyukovskiy's benchmarks chart shows that streaming mode PR degrades performance of byte array mode by ~30%. Upon further examination, it turned out that JIT C2 de-optimizes
next()andendOfJson()methods (the most performance critical methods) because of a newreloadBuffer()condition. Logically, this condition is never triggered in byte array mode, but apparently the condition invalidates some of JIT assumptions and previous optimizations.This PR decouples buffering logic from MaskingState to keep JIT optimizations for
next()andendOfJson()intact for byte array API.The preformance chart:
