Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save machine state #1579

Open
wants to merge 12 commits into
base: unstable
Choose a base branch
from

Conversation

MauveCloud
Copy link
Collaborator

@MauveCloud MauveCloud commented Oct 28, 2020

See #1576
Allows machines to save more state than before when harvested (they already saved covers, paint, and some other things):

  1. fluid in input and output tanks
  2. fluid and item auto-output settings
  3. stored energy
  4. processing enabled/disabled state (i.e. whether you stopped it with a soft mallet)
  5. item inventory
  6. original main facing (so covers can be rotated for new main facing) - extra semi-related feature: rotating main facing (even if not harvesting machine) will rotate covers as well

Also takes care of quantum tanks and fluid input/output hatches.
Including fluid/item auto-output setting, and fluid output tank (the input tank is handled by the parent class).
Either when placing a harvested machine that had covers, or when adjusting the main facing of a machine with a wrench.
@draknyte1
Copy link
Collaborator

Machines should not keep their contents when broken.

@MauveCloud
Copy link
Collaborator Author

I wonder how @leagris will react to that. Personally, I don't insist on it, since there are other mods that provide ways to move machines while keeping inventory, such as Mekanism cardboard boxes and apparently the DartCraft Force Wrench (and possibly others that I'm less familiar with). I guess I should trim this down to just the cover rotation part?

@leagris
Copy link
Contributor

leagris commented Oct 30, 2020

I just react that dropping fluid inventory on harvest just make the plunger and similar devices totally useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants