Update rust-bitcoin, rust-elements, rust-rocksdb and others #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, tiny_http, stderrlog, itertools, tempfile and ureq
And drop support for the `oldcpu` feature, which required an outdated rocksdb release (v0.12.4, released over 4 years ago)
|
I verified DB compatibility by loading a database initially created with fd35014. |
This was referenced Feb 13, 2024
shesek
commented
Feb 15, 2024
| @@ -26,7 +26,7 @@ impl<'a> Iterator for ScanIterator<'a> { | |||
| if self.done { | |||
| return None; | |||
| } | |||
| let (key, value) = self.iter.next()?; | |||
| let (key, value) = self.iter.next()?.expect("valid iterator"); | |||
There was a problem hiding this comment.
rust-rocksdb was changed to iterate over a Result that may contain an error if the iteration fails.
Previously the iterator was terminated with a None and it was expected that users of the library manually check iter.status() for errors after calling next(), which we did not do -- meaning that errors were ignored.
mempool/electrs#16 updated rust-rocksdb while keeping the old behavior, but it seems more correct to panic on errors as I implemented here.
|
utACK 255fb17, assuming we want to drop support for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.