Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galactica Xenobio and Security Fixes #2507

Merged
merged 8 commits into from
Sep 1, 2023

Conversation

SerynEngi
Copy link
Contributor

@SerynEngi SerynEngi commented Aug 5, 2023

About The Pull Request

Fixes #2506 and a host of other mapping errors. Also updates the security of security department by electrifying windows, doors and assigning correct permissions to external and internal security doors.

Why It's Good For The Game

Fix Man Good. Prisoners escaping without first outsmarting sec, bad. Torps not properly arriving at munitions from gulag bad.

muni output updated

Changelog

🆑
add: Added wire nodes for all Sec Dept. doors and windows on the Galactica
add: Added an breathing air tank dispenser to atmos storage on the Galactica
add: Added 4 borg chargers to the lower deck of the Galactica in various locations.
fix: Added disposals output to gulag torp disposal pipe in munitions on the galactica.
fix: Fixed a couple mapping issues with the Galactica Xenobio
fix: Corrected Sec Dept. Airlock permissions on the Galactica
fix: Properly connected PDSR output piping
/:cl:

@SerynEngi SerynEngi requested a review from a team as a code owner August 5, 2023 18:09
@SerynEngi SerynEngi changed the title Galactica Xenobio Fixes Galactica Xenobio and Security Fixes Aug 5, 2023
@Bokkiewokkie
Copy link
Contributor

image
There's supposed to be like, openspace here, so people can actually walk up/down the stairs

@SerynEngi
Copy link
Contributor Author

image There's supposed to be like, openspace here, so people can actually walk up/down the stairs

I haven't noted the stairs not functioning as intended there, but you're right, it may help people to notice that there are stairs there.

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put electric grilles like that delivery one on a mail pipe like that. If security leaves a convict in a room with the shutter open that's on them. Prisoners can still get gulag points from torp building without it being opened.
You've also left a lone window and disposal pipe in the hallway outside munitions.

@SerynEngi
Copy link
Contributor Author

SerynEngi commented Aug 12, 2023

Don't put electric grilles like that delivery one on a mail pipe like that. If security leaves a convict in a room with the shutter open that's on them. Prisoners can still get gulag points from torp building without it being opened. You've also left a lone window and disposal pipe in the hallway outside munitions.

Updated as requested.

muni output updated

@Bokkiewokkie Bokkiewokkie merged commit a2586d1 into BeeStation:master Sep 1, 2023
9 checks passed
@SerynEngi SerynEngi deleted the MoreGalacticaFixes branch July 21, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Galatica Xenobio issues
2 participants