Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for entities named from 'Hxxx' to 'Rxxx'. #258

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

yangqing8230
Copy link
Contributor

Hi BatchDrake
I just made a PR for adding Chinese translation of UI terms, including HistogramDialog, LogDialog, MainSpectrum, MfControl, NetForwarderUI, PanoramicDialog, QuickConnectDialog, RMSInspector, RMSViewer, RMSViewerSettingsDialog.
Cheers,

<message>
<location filename="../ui/HistogramDialog.ui" line="117"/>
<source>Sampling space</source>
<translation type="finished">采样间隔</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here "sampling space" perhaps should be named "sampling domain". It refers to which particular aspect of the waveform we are sampling (e.g. frequency, amplitude or phase). I believe "间隔" is more like interval, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, glad to see you BatchDrake.
Yes, It should be "sampling domain", "采样域" in Chinese.
And I didn't find some words such like 'Frequency' or 'Phase' in this context, so I checked out the widget source code, It seems that you change the label text in runtime. If so, the Chinese translation may not work properly I think.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this happens on several other places too (although luckily the biggest amount of translatable text is in the UI files).

@BatchDrake
Copy link
Owner

Hi Yáng, and sorry for the late answer. There are just one minor comment. Address it and I will merge ASAP.

@BatchDrake BatchDrake merged commit 143b356 into BatchDrake:master Oct 6, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants