Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for 8 entities named 'Exxx' to 'Gxxx'. #256

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

yangqing8230
Copy link
Contributor

Hi BatchDrake:
I just added Chinese translation for these files including "EqualizerControl", "EstimatorControl", "FileSourcePage", "FloatingTabWindow", "FrequencyCorrectionDialog", "GainControl", "GainSlider", "GenericInspector".

<message>
<location filename="../ui/FrequencyCorrectionDialog.ui" line="230"/>
<source>Azimuth</source>
<translation type="finished">水平</translation>
Copy link
Owner

@BatchDrake BatchDrake Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you translate Azimuth as 水平 and not as 方位角?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I will correct it. I'm not familiar with Space Physics terms, which lead to some misunderstanding in translating FrequencyCorrectionDialog.

<message>
<location filename="../ui/FrequencyCorrectionDialog.ui" line="249"/>
<source>Inclination</source>
<translation type="finished">倾斜度</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here inclination is a technical term referring to how the orbital plane of the satellite is tilted with respect to the equatorial plane. What do you think about translating this as "軌道傾角"? (like in https://zh.wikipedia.org/wiki/%E8%BB%8C%E9%81%93%E5%82%BE%E8%A7%92)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it. It's a technical term.

<message>
<location filename="../ui/FrequencyCorrectionDialog.ui" line="323"/>
<source>Rise in XX:XX:XX</source>
<translation type="finished">在XX:XX:XX上升</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, does this translation mean "rising at " or " to rise"? Because with this text what I mean the ETA for the satellite to rise, like, how much you have to wait before observing the satellite rising.

Copy link
Contributor Author

@yangqing8230 yangqing8230 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't quit get the point. Does 'XX:XX:XX' refer to a time point in the future just like ETA, or a time span, like 2 hour:15min:10sec, you have to wait.
And does 'rise' mean that the satellite will emerge from horizontal?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more like a time span, yes. "You have to wait XX:XX:XX to see the satellite rising". Rise means that the satellite goes from below horizon to above horizon (i.e. when its altitude becomes a positive angle)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to say, altitude and elevation in the sky coordinate jargon both refer to the same angle. You will see in the literature "Azimuth and elevation" or "Azimuth and altitude".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. And I remember that I've translated 'Altitude' to '海拔' and not a angle, (line 736), Is it correct?

<message>
<location filename="../ui/FrequencyCorrectionDialog.ui" line="368"/>
<source>Elevation</source>
<translation type="finished">海拔</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be translated to something like "高度角" as it is an angle above the horizon, not a distance (see https://zh.wikipedia.org/wiki/%E5%9C%B0%E5%B9%B3%E5%9D%90%E6%A8%99%E7%B3%BB)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll correct this. All the 'Azimuth', 'Elevation' stuff, represent angles.

<message>
<location filename="../Default/GenericInspector/GenericInspector.ui" line="204"/>
<source>Elevation</source>
<translation type="finished">海拔</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as earlier, Elevation here is actually an angle above the horizon (not a distance / depth).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally accept.

<message>
<location filename="../Default/GenericInspector/GenericInspector.ui" line="242"/>
<source>Airmass</source>
<translation type="finished">气团</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a literal translation when it should have been a technical term (大气质量, perhaps? See https://zh.wikipedia.org/wiki/%E5%A4%A7%E6%B0%94%E8%B4%A8%E9%87%8F_(%E5%A4%AA%E9%98%B3%E8%83%BD) )

The idea of the air mass is that as you look closer to the horizon, the apparent thickness of atmosphere you observe is bigger, as light (radio waves) arrives in diagonal. It is a number that goes from 1 (if you look right above your head) to infinity (if you look right to the horizon). Of course you will never have infinity air mass in practice, as it would mean the Earth had infinite radius (which we know it hasn't).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse my ignorance.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! These discussions are part of the translation process. There's a bunch of mixed, field-specific terminology here, you are not supposed to know everything about them without further context.

<message>
<location filename="../Default/GenericInspector/GenericInspector.ui" line="315"/>
<source>Azimuth</source>
<translation type="finished">水平</translation>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above discussion about "azimuth"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angle stuff, I got it. should be '方位角'

@BatchDrake
Copy link
Owner

Hi Yáng, thanks for the PR!

Address my comments above and I will merge this ASAP.

@BatchDrake BatchDrake merged commit 8fd8e34 into BatchDrake:master Sep 12, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants