Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch fully to numpy.trapz and fix numpy version #815

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

karllark
Copy link
Member

@karllark karllark commented Jul 29, 2024

Fixes three different test errors.

Numpy version fixed to 1.26.4 to avoid issues with upstream packages being compiled to different libraries (mismatch of variable sizes).

Remove last use of scipy.trapz by switching to numpy.trapz. Scipy seems to have renamed their function to trapezoid.

Updated codecov to v4 (from v1) to fix upload rate limit issue.

@karllark karllark merged commit ef6b0c6 into BEAST-Fitting:master Jul 29, 2024
8 checks passed
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.92%. Comparing base (a66947b) to head (002945b).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
beast/observationmodel/phot.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   42.00%   41.92%   -0.09%     
==========================================
  Files         108      108              
  Lines       10279    10264      -15     
==========================================
- Hits         4318     4303      -15     
  Misses       5961     5961              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant