[TokenCache] Downgrade dependency version for Microsoft.Extensions on net472 #1663
Conversation
Microsoft.Extensions.* 5.0 removed a component which breaks Kestrel when running on Net Framework. I'm only adjusting the net472 target because net462 users typically wouldn't be using Kestrel due to some challenges with netstandard packages.
stephenjust
changed the title
| <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.DataProtection" Version="5.0.8" /> | ||
| <PackageReference Include="System.Text.Encodings.Web" Version="5.0.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net472'"> |
There was a problem hiding this comment.
@jennyf19 @jmprieur @pmaytak - this package has no conditional compilation at all, so the only reason we have all these frameworks it to be able to have different dependencies, i.e. different versions of dependencies.
In particular, net462 and net472 seem identical?
If we get net4x2 to have the same dependencies as netstandard, we might as well eliminate net4x2 completely.
There was a problem hiding this comment.
I don't remember the details of the investigation into the target framework, but I see that some packages try to simplify things into supporting only netstandard2.0.
https://www.nuget.org/packages/Microsoft.Extensions.Configuration.AzureKeyVault/
There was a problem hiding this comment.
I will note that while I was trying to assemble a simple repro of this issue, a project on net462 used the netstandard dependency set for some reason, while net472 used the expected net472 dependencies. I didn't look into it too deeply though, my org's projects are all net472.
There was a problem hiding this comment.
LGTM
I agree that net472 brings netstandard20
Thanks @stephenjust
cc: @GeoK
|
Can you please make this change for net462 as well? |
What would be the reason, @jayesh-a-shah ? We carefully chose the dependencies, and unless there is a blocker with repro steps, I'm not going to accept that they are changed. @stephenjust @jayesh-a-shah out of curiosity, did you try to bump-up these extensions to version 8? this is what the .NET team recommends now. |
Fixes #1662
Microsoft.Extensions.* 5.0 removed a component which breaks Kestrel when running on Net Framework.
I'm only adjusting the net472 target because net462 users typically wouldn't be using Kestrel due to some challenges with netstandard packages.