Enable broker support on Linux #766
Conversation
|
/azp run MSAL-Python-SDL-CI |
| pymsalruntime>=0.17,<0.18; python_version>='3.8' and platform_system=='Darwin' | ||
| pymsalruntime>=0.17,<0.19; python_version>='3.8' and platform_system=='Darwin' | ||
| # PyMsalRuntime 0.18+ is expected to support broker on Linux | ||
| pymsalruntime>=0.18,<0.19; python_version>='3.8' and platform_system=='Linux' |
There was a problem hiding this comment.
Have you released or do you plan to release 0.18.0 for Linux? I saw right now it's still 0.17.1
https://pypi.org/project/pymsalruntime/#history
There was a problem hiding this comment.
I have not yet released 0.18.0, but i'll be making that release soon, and this will be the first package with linux broker support
There was a problem hiding this comment.
suggestion: This PR shall be changed to a draft. We won't merge it in until pymsalruntime 0.18 being released.
There was a problem hiding this comment.
Can we ensure the next release of pymsalruntime have whls built for Python 3.13 as well? The latest version of pymsalruntime doesn't seem to have that.
| @@ -39,7 +39,8 @@ | |||
| _AZURE_CLI, | |||
| authority="https://login.microsoftonline.com/organizations", | |||
| enable_broker_on_mac=True, | |||
| enable_broker_on_windows=True) | |||
There was a problem hiding this comment.
Thanks, you find this test file, please make sure it is able to invoke broker and you need to manually finish the signin process in the broker prompt.
| @@ -200,6 +200,7 @@ def _build_app(cls, | |||
| http_client=http_client or MinimalHttpClient(), | |||
| enable_broker_on_windows=broker_available, | |||
| enable_broker_on_mac=broker_available, | |||
| enable_broker_on_linux=broker_available, | |||
There was a problem hiding this comment.
praise: Thanks for finding this test file!
suggestion: If you haven't already, please also do python -m unittest tests.test_e2e and make sure we won't run into any issue. Note that you will need to setup an .env first, whose content is described at the beginning of this test_e2e.py file.
Co-authored-by: Ray Luo <[email protected]>
Co-authored-by: Ray Luo <[email protected]>
Co-authored-by: Ray Luo <[email protected]>
There was a problem hiding this comment.
We will also need to change the precise dependency version error message here and a approximate version hint there
| @@ -1921,7 +1921,7 @@ def __init__(self, client_id, client_credential=None, **kwargs): | |||
|
|
|||
| .. note:: | |||
|
|
|||
| You may set enable_broker_on_windows and/or enable_broker_on_mac to True. | |||
| You may set enable_broker_on_windows and/or enable_broker_on_mac and/or enable_broker_on_linux to True. | |||
There was a problem hiding this comment.
Question: Does the Linux broker require yet another new redirect_uri being registered? If so, please also update the documentation here.
No description provided.