Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CAE capability for Managed Identity flows #4719
base: main
Are you sure you want to change the base?
Add CAE capability for Managed Identity flows #4719
Changes from 27 commits
d145191
ab33420
d78eb83
3f8c9ca
88596ce
cf4fe68
d72353e
d36ba52
361b68d
9b12091
b80e8b7
3f0f3c7
620cf79
270a3d3
bba95fc
c6d9712
bd3db18
fc87993
c90bba6
dc387af
512434e
15d6b7e
b294b15
467c1b4
b195572
a1efed5
4e44131
fb92a24
36234e2
d48eb4e
d23ce5a
f2d2a9a
edcb66a
8499da3
68c65ba
0f4a3f0
ca1a0b6
070c34c
3121cc6
0fa96f7
5ec1fda
f1d14cc
1e816d3
4051422
2eeee66
d45adbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is not always available for managed identity flows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would it look like when the API is not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to cache these here when you have the
KeyMaterialManager
which gets or creates them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgavrilMS @localden for public API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about consistently using
Is
prefix?IsClientSupportingClaims
?cc: @gladjohn @bgavrilMS @pmaytak