Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target, compile SDK, AGP and gradle versions increased #1755

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Target, compile SDK, AGP and gradle versions increased #1755

merged 4 commits into from
Aug 24, 2023

Conversation

somalaya
Copy link
Contributor

@somalaya somalaya commented Aug 15, 2023 •
edited
Loading

  • Target sdk version changed to 33
  • Compile sdk version changed to 34
  • AGP version changed to 7.4.2
  • Gradle distribution url changed to 7.5

After changing above versions, I had to update other dependencies for compatibility

  • Powerlift version changed to 1.0.3
  • Bouncy castle version changed to 1.69
  • robolectric version to 4.9
  • Also, with new gradle versions, some of the properties used in gradle were deprecated (naming conventions changed). So, made those changes
  • With gradle version changes, we should not be having a package name in AndroidManifest.xml.. instead, should add a namespace property in build.gradle. https://developer.android.com/build/publish-library/prep-lib-release#choose-namespace
  • For apps targeting Android 14, Android restricts apps from sending implicit intents to internal app components. So , added exported attribute. https://developer.android.com/about/versions/14/behavior-changes-14#safer-intents
  • Renamed the assemble dist release aar name to contain the version number. Starting gradle version 7, gradle generates adal-dist-release.aar. But we want to publish adal-5.0.0.aar

@somalaya somalaya changed the title Somalaya/gradle version increase Target, compile SDK, AGP and gradle versions increased Aug 15, 2023
@somalaya somalaya marked this pull request as ready for review August 15, 2023 15:43
@somalaya somalaya requested a review from a team as a code owner August 15, 2023 15:43
iamgusain
iamgusain reviewed Aug 21, 2023
View reviewed changes
adal/build.gradle Outdated Show resolved Hide resolved
@somalaya somalaya force-pushed the somalaya/gradleVersionIncrease branch from 1c99e39 to 1711172 Compare August 24, 2023 23:43
somalaya and others added 4 commits August 24, 2023 16:45
@somalaya
Merging somalaya/release/4.7.1 to release/4.7.1 (#1736)
9639e1c 
* updated versions.properties, build.gradle & changeLog

* changed RC1 to RC3 as RC1 and RC2 are already pushed in Jul 2022

* updated common to RC2

* version changed to 4.7.0

* updated to RC3

* removed RC tags

* updated changeLog, version.props and buildGradle
@somalaya
target and compile sdk to 34
b692c31
@somalaya
updated common
0020247
@somalaya
rebased with dev
0aa3093
@somalaya somalaya force-pushed the somalaya/gradleVersionIncrease branch from 1711172 to 0aa3093 Compare August 24, 2023 23:48
@somalaya somalaya merged commit 14dc08f into dev Aug 24, 2023
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissaahn melissaahn melissaahn approved these changes

@iamgusain iamgusain iamgusain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somalaya @iamgusain @melissaahn