Drop .NET 6 Support #2432
Open
Drop .NET 6 Support #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
seantleonard
requested review from
Aniruddh25,
aaronburtle,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
|
Should we make changes in the scripts as well? FileName : scripts.publish.ps1 |
sezal98
approved these changes
Oct 22, 2024
| @@ -281,7 +281,6 @@ private void InitializeObjects() | |||
| { | |||
| _options = new() | |||
| { | |||
| #if NET8_0_OR_GREATER | |||
| // ObjectConverter behavior different in .NET8 most likely due to | |||
| // .NET7 breaking change: | |||
| // - https://learn.microsoft.com/dotnet/core/compatibility/serialization/7.0/polymorphic-serialization#affected-apis | |||
There was a problem hiding this comment.
We should modify the comments according to the new changes
| @@ -42,25 +41,6 @@ public SimulatorAuthenticationHandler( | |||
| : base(options, logger, encoder) | |||
There was a problem hiding this comment.
Can be removed ?
// ISystemClock is obsolete in .NET 8.0 and later
// https://learn.microsoft.com/dotnet/core/compatibility/aspnet-core/8.0/isystemclock-obsolete
Aniruddh25
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Good initiative, we should check with @neeraj-sharma2592 with respect to dependencies on hosting before merging
I'm in touch with Neeraj for the same. Will add update accordingly. |
|
Both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
src/Directory.Packages.propsHow was this tested?