-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to managed code version of functionsnethost #1704
Merged
kshyju
merged 18 commits into
main
from
shkr/rebase_on_main-feature-functionsnethost-managedcode
Jul 26, 2023
Merged
Switching to managed code version of functionsnethost #1704
kshyju
merged 18 commits into
main
from
shkr/rebase_on_main-feature-functionsnethost-managedcode
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
requested review from
fabiocav and
brettsam
and removed request for
fabiocav
June 30, 2023 01:03
I may create another PR just to adjust the version numbers of the packages when we are ready to release. |
satvu
approved these changes
Jul 5, 2023
satvu
reviewed
Jul 5, 2023
satvu
reviewed
Jul 5, 2023
satvu
reviewed
Jul 5, 2023
host/src/FunctionsNetHost/Environment/EnvironmentSettingNames.cs
Outdated
Show resolved
Hide resolved
liliankasem
reviewed
Jul 6, 2023
First iteration of Azure Functions Custom .NET Host(Validated in Windows)
* Adding support for linux cold start. * Using native "get_hostfxr_path" method from "nethost". Removed PathResolver code (which was our version to do the same thing) * Update build YAML to copy all files instead of just .exe. * Linted yaml file. fixed the copy step to copy only needed dependencies * YAML * Get the NativeApplication instance from pointer and call the methods instead of static method call. * Revert "Get the NativeApplication instance from pointer and call the methods instead of static method call." This reverts commit 2f54a1c. * Using NET8 Preview4. * NET6 support on Debian * Version bump for DotNetIsolatedNativeHost package * Add net6.0;net7.0; to TargetFrameworks. * Removing the shim for Windows.
…sprok to include net6.0;net7.0;
kshyju
force-pushed
the
shkr/rebase_on_main-feature-functionsnethost-managedcode
branch
from
July 11, 2023 18:16
4243ff4
to
4d7cd80
Compare
Rebased on main again this morning. |
fabiocav
reviewed
Jul 19, 2023
fabiocav
approved these changes
Jul 21, 2023
…T8 since our root level one uses 7.0. We use .NET AOT compiler to publish the FunctionsNetHost.
…e' of https://github.com/Azure/azure-functions-dotnet-worker into shkr/rebase_on_main-feature-functionsnethost-managedcode
…testMinor" in FunctionsNetHost/src/global.json
kshyju
deleted the
shkr/rebase_on_main-feature-functionsnethost-managedcode
branch
July 26, 2023 21:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in changes from feature branch to main.
The PR branch was created from the feature branch and then rebased on top of main. Only conflicts were the in the DotnetWorker.csproj and DotnetWorker.Grpc.csproj, I took the feature branch version during rebase. Updated these 2 files later to reflect the new version numbers we want.
I may create another PR just to adjust the version numbers of the packages when we are ready to release.