Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Client encryption]: Fixes handling of escaped utf8 strings in StreamProcessor #4871

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[Client encryption]: Fixes handling of escaped utf8 strings in StreamProcessor #4871

wants to merge 7 commits into from

Conversation

JanHyka
Copy link
Contributor

@JanHyka JanHyka commented Nov 6, 2024

Pull Request Template

Description

  • StreamProcessor now correctly handles escaped utf8 values in property names and values where applicable.
  • Unit test extended to cover non ASCII characters cases
  • Small cleanup in StreamProcessor (Shared code between encryptor and decryptor is in separate file)
  • Reduce allocations on StreamProcessor

Note change in benchmark hardware, actual difference before and after change:
image

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)

Closing issues

Contributes to #4678

@JanHyka
+ sanitize escapable json elements on Stream processor path
490eec8 
+ test coverage
+ reduce excessive string allocations on encryption path
@JanHyka
+ benchmark
1095e1c
@JanHyka
Copy link
Contributor Author

JanHyka commented Nov 6, 2024

@microsoft-github-policy-service agree

@kirankumarkolli
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanHyka @kirankumarkolli