[Internal] Query: Adds Query Advice Request and Response capabilities #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leminh98
requested review from
a team,
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
added 2 commits
October 28, 2024 03:49
…thub.com/Azure/azure-cosmos-dotnet-v3 into users/leminh/QueryAdvisorRequestResponse
leminh98
changed the title
sboshra
reviewed
Nov 12, 2024
| @@ -433,6 +435,8 @@ public ChangeFeedEstimatorEmptyFeedResponse(ITrace trace) | |||
|
|
|||
| public override string IndexMetrics => string.Empty; | |||
|
|
|||
| public override string QueryAdvice => string.Empty; | |||
sboshra
reviewed
Nov 12, 2024
| /// </summary> | ||
| /// <value> | ||
| /// The index utilization metrics. | ||
| /// </value> |
sboshra
reviewed
Nov 12, 2024
| sealed class QueryAdvice | ||
| { | ||
| [JsonConstructor] | ||
| public QueryAdvice(IReadOnlyList<SingleQueryAdvice> queryAdvices) |
sboshra
reviewed
Nov 12, 2024
| sealed class QueryAdvice | ||
| { | ||
| [JsonConstructor] | ||
| public QueryAdvice(IReadOnlyList<SingleQueryAdvice> queryAdvices) |
sboshra
reviewed
Nov 12, 2024
| } | ||
| } | ||
|
|
||
| public static string ToString(QueryAdvice advice) |
There was a problem hiding this comment.
override ToString rather than static function
sboshra
reviewed
Nov 12, 2024
| return String.Empty; | ||
| } | ||
|
|
||
| string result = String.Empty; |
sboshra
reviewed
Nov 12, 2024
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
override ToString instead of static function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds the capability to request and receive Query Advice in QueryRequests. The response from BE is an URL-encoded JSON string that will get decoded to UTF8 text.
To request query advice, use the new
QueryRequestOpton.PopulateQueryAdviceOnce this is set to true, see the advice via
FeedResponse.QueryAdvicepropertyNote: the test is marked Ignore because the emulator used in pipeline does not support Query Advisor yet. Furthermore, this request option is internal and not yet public to wait for the deployment
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber