Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load From CDN #123

Open
wants to merge 11 commits into
base: preview
Choose a base branch
from

Conversation

zhiyuanliang-ms
Copy link
Contributor

@zhiyuanliang-ms zhiyuanliang-ms commented Nov 4, 2024

Only the latest preview version of App Config service supports the sas token authentication which the CDN will use.
The latest js sdk allows use to specify the api version manually. ref

Updated the dependency of sdk to 1.8.0.

@zhiyuanliang-ms zhiyuanliang-ms changed the title Use the correct api version when load from cdn Load From CDN Nov 5, 2024
@zhiyuanliang-ms
Copy link
Contributor Author

zhiyuanliang-ms commented Nov 5, 2024

I reverted the original commit of adding loadFromCdn (#130) to unblock doing release for EXP telemetry changes.
We still have the issue with supporting dynamic refresh for CDN scenario:

  1. You are not guaranteed to get the latest etag of sentinal key because cdn's cache may not expired. During refresh we should force cdn to pull the latest etag.

This PR will contains all changes of the complete solution of loading from cdn.

src/load.ts Outdated Show resolved Hide resolved
@zhiyuanliang-ms zhiyuanliang-ms force-pushed the zhiyuanliang/enforce-api-version-for-cdn branch from 1eaa43e to 62ac2b9 Compare November 10, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants