-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: do not display block placeholder to non-admins #40209
base: trunk
Are you sure you want to change the base?
Conversation
We currently display a placeholder in the block editor when a block cannot be used because its associated module is not active. The placeholder offers a button inviting folks to activate the module. Since only admins can activate modules, the placeholder is useless to non-admins. Let's consequently skip registering the blocks for non-admins when the associated module is not active.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Proposed changes:
We currently display a placeholder in the block editor when a block cannot be used because its associated module is not active. The placeholder offers a button inviting folks to activate the module.
Since only admins can activate modules, the placeholder is useless to non-admins. Let's consequently skip registering the blocks for non-admins when the associated module is not active.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/subscribe