-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Permissions API #229
base: dev/v2
Are you sure you want to change the base?
Conversation
api/src/main/java/me/lokka30/treasury/api/permission/Context.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/permission/NodeHolder.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/permission/NodeHolder.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/permission/PermissionsProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ivan! I've taken a look at what you've currently implemented, and left some comments.
there's another problem we need to discuss: that's about prefix and suffix nodes. their data type is a component. but the problem is that spigot and bungeecord utilize bungeecord-chat whilst any other server/proxy implementation (sponge, velocity, paper, etc.) utilizes adventure. if we opt in for bungeecord-chat components, then we need to download bungeecord-chat for the platforms where they don't have it and translate bungeecord-chat -> adventure, or the reverse, if we opt in for adventure components, then we need to download adventure for the platforms where they don't have it and translate adventure -> bungeecord-chat. a solution i thought of is create our own chat api, but that's basically just unnecessary reinvention of the wheel. |
Sorry for avandoning Treasury for so long. I just dont have time to keep up. But I saw that you're asking for help.
Are these two systems too diferent from each other? Couldn't you just abstract the common/neccessary functionality and use the abstraction on the api, but on the code have it call the system of the platform? |
Yes. Completely.
No. |
api/src/main/java/me/lokka30/treasury/api/permission/context/ContextType.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/permission/node/Node.java
Outdated
Show resolved
Hide resolved
Co-authored-by: montlikadani <[email protected]>
api/src/main/java/me/lokka30/treasury/api/permission/node/holder/NodeHolder.java
Outdated
Show resolved
Hide resolved
The only solution this ^. We could make a simplifed and small Component/NameComponent for these prefix/suffix to retrieve and change things. Or just a plain String as the last resort. |
I really don't want to think this is the only solution. An idea just passed through my mind and that is create a ComponentCreator that will spit out the component json, then consumers and implementors can shove that in bungee-chat or adventure and get a proper component. |
@Jikoo any thoughts/ideas? |
Probably not for at least a month or two based on how things are looking - my GPU is failing, which in turn makes pretty much everything quite frustrating. I was very spoiled by dual 1440p monitors, a single at 1024x768 is practically unusable. Please don't hold back on my account. |
…into new/permissions-api
This is not gonna push back the 2.0.0 release anymore. We will release this when it's ready. |
…into new/permissions-api
…into new/permissions-api
…into new/permissions-api
@Jikoo please implement your ideas whenever you can |
This is the next major item on my list, but my development time is currently being devoted to a plugin of mine that has apparently been partially broken since like 1.14 due to changes that weren't listed on the MC wiki (whoops). |
made them less complex to understand and work with
okay, I just reworked nodes btw |
…into new/permissions-api
…to new/permissions-api
…to new/permissions-api
it looks like to me there was 0 time to work on this :( . Anyone still interested in giving his ideas into writing this API? |
…to new/permissions-api
Currently, this lays the ground of a Permissions & Chat API for Treasury.
I'm opening this not just for discussion, but to implement sane ideas suggested in this PR.