Use latest upgrade executor #319
Conversation
| address public immutable newUpgradeExecutorImplementation = address(new UpgradeExecutor()); | ||
|
|
||
| function perform() external { | ||
| _upgradeTo(newUpgradeExecutorImplementation); |
There was a problem hiding this comment.
not a big fan of using ERC1967Upgrade to modify the storage slot directly, can we just have it go through the proxy admin instead?
There was a problem hiding this comment.
yeah we can do that, i have a couple versions at earlier commits that do
eg d74a6d9#diff-96112336c8e4f94e4f509a6e67874a61d2637890f110f1b10e95998a50996812
eg2 (gets proxy admin at perform time) 90fb0bc#diff-96112336c8e4f94e4f509a6e67874a61d2637890f110f1b10e95998a50996812
There was a problem hiding this comment.
reverted back to the first example
src/gov-action-contracts/AIPs/SecurityCouncilMgmt/GovernanceChainSCMgmtActivationAction.sol
Outdated
Show resolved
Hide resolved
| @@ -79,6 +79,7 @@ | |||
| "@arbitrum/nitro-contracts": "1.1.1", | |||
| "@arbitrum/token-bridge-contracts": "1.0.0-beta.0", | |||
| "@gnosis.pm/safe-contracts": "1.3.0", | |||
| "@offchainlabs/upgrade-executor": "1.1.1", | |||
There was a problem hiding this comment.
thinking if having governanceDeployer.ts to deploy UE using released bytecode would be an overkill
There was a problem hiding this comment.
if we do that we should also change the actions to take the executor impl address as a constructor argument right
There was a problem hiding this comment.
not sure what you mean, it seems to already taking an address of the logic contract
There was a problem hiding this comment.
it just takes proxy admins at the moment and deploys the implementation in the action's constructor. I thought it'd be easier than deploying them separately
There was a problem hiding this comment.
changed it
should merge #317 first
51db9a3 removes the
UpgradeExecutorsource and tests from this repo and replaces it with the@offchainlabs/upgrade-executornpm package. A lot of files needed small changes to buildthe other commits are the upgrade action and tests