Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post audit security council election upgrade action changes #237

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Post audit security council election upgrade action changes #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c7849
update action
godzillaba Jan 9, 2024
9b35fc5
add constitution hash
DZGoldman Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gov-action-contracts/AIPs/NomineeGovernorV2UpgradeAction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ contract NomineeGovernorV2UpgradeAction is NomineeGovernorV2UpgradeActionTemplat
constructor() NomineeGovernorV2UpgradeActionTemplate(
0xdb216562328215E010F819B5aBe947bad4ca961e,
0x8a1cDA8dee421cD06023470608605934c16A05a0,
address(0), // todo: new implementation
address(new SecurityCouncilNomineeElectionGovernor()),
50400,
0x1D62fFeB72e4c360CcBbacf7c965153b00260417,
0x0101010101010101010101010101010101010101010101010101010101010101 // todo: new constitution hash
0xefe6dbc1dbe4b921c3ba5828a2c8e9b965af5363df8d70e9ff88ae5fceca3159
) {}
}
3 changes: 2 additions & 1 deletion test/gov-actions/NomineeGovernorV2UpgradeAction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ contract NomineeGovernorV2UpgradeActionTest is Test {
UpgradeExecutor arbOneUe = UpgradeExecutor(0xCF57572261c7c2BCF21ffD220ea7d1a27D40A827);
address council = 0x423552c0F05baCCac5Bfa91C6dCF1dc53a0A1641;
IArbitrumDAOConstitution constitution = IArbitrumDAOConstitution(0x1D62fFeB72e4c360CcBbacf7c965153b00260417);
bytes32 newConstitutionHash = 0x0101010101010101010101010101010101010101010101010101010101010101;
// see https://github.com/ArbitrumFoundation/docs/pull/731/commits/0837520dccc12e56a25f62de90ff9e3869196d05
bytes32 newConstitutionHash = 0xe794b7d0466ffd4a33321ea14c307b2de987c3229cf858727052a6f4b8a19cc1;

address newImplementation = address(new SecurityCouncilNomineeElectionGovernor());
uint256 votingDelay = 7 days;
Expand Down
Loading