Skip to content

Commit

Permalink
Merge pull request #196 from ArbitrumFoundation/security-council-mgmt…
Browse files Browse the repository at this point in the history
…--fix-comment

fix comment in sc member removal gov
  • Loading branch information
DZGoldman authored Aug 15, 2023
2 parents 22d763e + f09ae22 commit 20d483a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
26 changes: 13 additions & 13 deletions .gas-snapshot
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ArbitrumFoundationVestingWalletTest:testProperlyInits() (gas: 16337546)
ArbitrumFoundationVestingWalletTest:testRandomAddressCantSetBeneficiary() (gas: 16329656)
ArbitrumFoundationVestingWalletTest:testRelease() (gas: 16448631)
ArbitrumVestingWalletFactoryTest:testDeploy() (gas: 4589688)
ArbitrumVestingWalletFactoryTest:testOnlyOwnerCanCreateWallets() (gas: 1504286)
ArbitrumVestingWalletFactoryTest:testOnlyOwnerCanCreateWallets() (gas: 1503439)
ArbitrumVestingWalletTest:testCastVote() (gas: 16201584)
ArbitrumVestingWalletTest:testCastVoteFailsForNonBeneficiary() (gas: 16151341)
ArbitrumVestingWalletTest:testClaim() (gas: 16007768)
Expand Down Expand Up @@ -116,7 +116,7 @@ SecurityCouncilManagerTest:testCohortMethods() (gas: 136185)
SecurityCouncilManagerTest:testInitialization() (gas: 193074)
SecurityCouncilManagerTest:testRemoveMember() (gas: 213029)
SecurityCouncilManagerTest:testRemoveMemberAffordances() (gas: 99074)
SecurityCouncilManagerTest:testRemoveSCAffordances() (gas: 81253)
SecurityCouncilManagerTest:testRemoveSCAffordances() (gas: 80391)
SecurityCouncilManagerTest:testRemoveSeC() (gas: 38309)
SecurityCouncilManagerTest:testReplaceMemberAffordances() (gas: 208560)
SecurityCouncilManagerTest:testReplaceMemberInFirstCohort() (gas: 258788)
Expand All @@ -127,23 +127,23 @@ SecurityCouncilManagerTest:testUpdateFirstCohort() (gas: 295311)
SecurityCouncilManagerTest:testUpdateRouter() (gas: 76296)
SecurityCouncilManagerTest:testUpdateRouterAffordacnes() (gas: 112379)
SecurityCouncilManagerTest:testUpdateSecondCohort() (gas: 295316)
SecurityCouncilMemberElectionGovernorTest:testCannotUseMoreVotesThanAvailable() (gas: 246997)
SecurityCouncilMemberElectionGovernorTest:testCannotUseMoreVotesThanAvailable() (gas: 246047)
SecurityCouncilMemberElectionGovernorTest:testCastBySig() (gas: 302832)
SecurityCouncilMemberElectionGovernorTest:testCastBySigTwice() (gas: 266284)
SecurityCouncilMemberElectionGovernorTest:testCastVoteReverts() (gas: 35277)
SecurityCouncilMemberElectionGovernorTest:testCastVoteReverts() (gas: 33308)
SecurityCouncilMemberElectionGovernorTest:testExecute() (gas: 665450)
SecurityCouncilMemberElectionGovernorTest:testForceSupport() (gas: 165349)
SecurityCouncilMemberElectionGovernorTest:testInitReverts() (gas: 4922497)
SecurityCouncilMemberElectionGovernorTest:testInvalidParams() (gas: 165321)
SecurityCouncilMemberElectionGovernorTest:testMiscVotesViews() (gas: 227939)
SecurityCouncilMemberElectionGovernorTest:testNoVoteForNonCompliantNominee() (gas: 123524)
SecurityCouncilMemberElectionGovernorTest:testNoZeroWeightVotes() (gas: 169595)
SecurityCouncilMemberElectionGovernorTest:testOnlyNomineeElectionGovernorCanPropose() (gas: 111038)
SecurityCouncilMemberElectionGovernorTest:testOnlyNomineeElectionGovernorCanPropose() (gas: 110129)
SecurityCouncilMemberElectionGovernorTest:testProperInitialization() (gas: 49388)
SecurityCouncilMemberElectionGovernorTest:testProposeReverts() (gas: 32916)
SecurityCouncilMemberElectionGovernorTest:testProposeReverts() (gas: 32049)
SecurityCouncilMemberElectionGovernorTest:testRelay() (gas: 42229)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNominees(uint256) (runs: 256, μ: 340004, ~: 339432)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNomineesFails() (gas: 273335)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNominees(uint256) (runs: 256, μ: 340043, ~: 339372)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNomineesFails() (gas: 269518)
SecurityCouncilMemberElectionGovernorTest:testSetFullWeightDuration() (gas: 34951)
SecurityCouncilMemberElectionGovernorTest:testVotesToWeight() (gas: 152898)
SecurityCouncilMemberRemovalGovernorTest:testInitFails() (gas: 10159193)
Expand Down Expand Up @@ -179,11 +179,11 @@ SecurityCouncilMgmtUtilsTests:testIsInArray() (gas: 2102)
SecurityCouncilNomineeElectionGovernorTest:testAddContender() (gas: 215127)
SecurityCouncilNomineeElectionGovernorTest:testCastBySig() (gas: 318348)
SecurityCouncilNomineeElectionGovernorTest:testCastBySigTwice() (gas: 281704)
SecurityCouncilNomineeElectionGovernorTest:testCastVoteReverts() (gas: 35255)
SecurityCouncilNomineeElectionGovernorTest:testCountVote() (gas: 542695)
SecurityCouncilNomineeElectionGovernorTest:testCreateElection() (gas: 253049)
SecurityCouncilNomineeElectionGovernorTest:testCastVoteReverts() (gas: 33286)
SecurityCouncilNomineeElectionGovernorTest:testCountVote() (gas: 539123)
SecurityCouncilNomineeElectionGovernorTest:testCreateElection() (gas: 249623)
SecurityCouncilNomineeElectionGovernorTest:testExcludeNominee() (gas: 431856)
SecurityCouncilNomineeElectionGovernorTest:testExecute() (gas: 671552)
SecurityCouncilNomineeElectionGovernorTest:testExecute() (gas: 667741)
SecurityCouncilNomineeElectionGovernorTest:testForceSupport() (gas: 176798)
SecurityCouncilNomineeElectionGovernorTest:testIncludeNominee() (gas: 644396)
SecurityCouncilNomineeElectionGovernorTest:testInvalidInit() (gas: 7095881)
Expand Down Expand Up @@ -233,7 +233,7 @@ TokenDistributorTest:testZeroReceiver() (gas: 4132675)
TokenDistributorTest:testZeroToken() (gas: 71889)
TopNomineesGasTest:testTopNomineesGas() (gas: 4502786)
UpgradeExecRouteBuilderTest:testAIP1Point2() (gas: 1322645)
UpgradeExecRouteBuilderTest:testRouteBuilderErrors() (gas: 1127374)
UpgradeExecRouteBuilderTest:testRouteBuilderErrors() (gas: 1116745)
UpgradeExecutorTest:testAdminCanChangeExecutor() (gas: 2583801)
UpgradeExecutorTest:testCantExecuteEOA() (gas: 2439721)
UpgradeExecutorTest:testExecute() (gas: 2677995)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ contract SecurityCouncilMemberRemovalGovernor is
{
(uint256 againstVotes, uint256 forVotes,) = proposalVotes(proposalId);

// for-votes / total-votes > success-numerator/ success-denominator
// for-votes / total-votes >= success-numerator/ success-denominator
return
VOTE_SUCCESS_DENOMINATOR * forVotes >= (forVotes + againstVotes) * voteSuccessNumerator;
}
Expand Down

0 comments on commit 20d483a

Please sign in to comment.