Fix vendor_id should be a integer console error #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumaisa-mou
approved these changes
Oct 24, 2022
sumaisa-mou
reviewed
Oct 26, 2022
| }); | ||
| } | ||
|
|
||
| function appseroPaddleEvent(data) { | ||
|
|
||
| if( data.event === 'Checkout.Complete' ) { | ||
| if (data.event === "Checkout.Complete") { |
There was a problem hiding this comment.
May we know the reason for replacing single quote with double quote?
There was a problem hiding this comment.
It was just a eslint fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason there is a need of vendor id for paddle even if we use FastSpring. But the fields for paddle is hidden and not saving anything while paddle not selected. So I make sure at least the paddle vendor id field will remain save event if we change the payment solution.
Another thing is on JavaScript we should must
parseInttheappseroPaddleAffWP.vendor_idbefore using to confirm it's a integer.