Fixes #1
Fixes #1
Conversation
…to make it behave correctly.
Made some other fixes.
|
Hi, and thanks for the PR ! This is looking good ! I will merge it but I saw that your kaitaiStructCompile failed to build on travis, will it have an impact on my project ? |
I don't know, it needs some investigation, travis logs show that they fail on the stage of upgrading setuptools and for me for now it's not clear why it fails there. The tool is very alpha quality (it doesn't mean it shouldn't be used, we are all developers and from developers I expect ability to fix some minor flaws and ability to create PR and issues on bug tracker, the tool won't improve itself, it's developers who improve things), and even if it was release quality I would not guarantee anything. You know: every dependency poses some risk and every update too, even super-popular libraries like sympy are not immune to it. So I guess that you can start merging the changes not introducing the dependency leaving the one involving the dependency for later, they are pretty permutable. Though I insist on testing of every change before merging. Please also note that the tool is explicitly incompatible with python 2 by design: python 3.7 is called the last release of python 3, the next one will be python 4, and we don't want the hell of supporting 3 incompatible versions, python 2 needs coup de grace (like x86_32 and Windows XP and old Androids do, but unlike it (I beleive we shouldn't say people that they must pay Intel, Microsoft, Google and Samsung in order to use our software ) python 3 works even on ancient OSes and hardware, I have seen a PIII PC with 256 MiB of RAM running python 3.7 pretty well, so everyone can upgrade), everyone realizes it, lot of projects have dropped it. So lack of support for python 2 in my libs is my small contribution to that coup de grace. So if you need it be buildable with python 2 you cannot use it (at least in my edition, but you are free to fork). |
No description provided.