Ci improvements #229
Ci improvements #229
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| - name: Run Foundry tests | ||
| run: yarn foundry:test | ||
| env: | ||
| ETH_NODE_URI_MAINNET: ${{ secrets.ETH_NODE_URI_MAINNET }} | ||
| ETH_NODE_URI_POLYGON: ${{ secrets.ETH_NODE_URI_POLYGON }} | ||
| ETH_NODE_URI_GOERLI: ${{ secrets.ETH_NODE_URI_GOERLI }} | ||
| ETH_NODE_URI_FANTOM: ${{ secrets.ETH_NODE_URI_FANTOM }} | ||
| FOUNDRY_FUZZ_RUNS: "5000" |
There was a problem hiding this comment.
why is it not set as a variable as ci-deep?
There was a problem hiding this comment.
I thought it would be better to just set it as env because I don't believe it will be useful to change it as input
|
Failing foundry test... |
0xtekgrinder
force-pushed
the
chore/ci-improvements
branch
from
52bb6c4
to
f3f510d
Compare
Fix the tests and improve the CI by adding a few things: