Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade ESLint to v9 #275

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

RubenSibon
Copy link
Contributor

No description provided.

- Switch to flat eslint config
- Modify tsconfig
- Remove unnecessary rule disable
},
"overrides": {
"eslint": "$eslint",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line prevents me from installing the packages.

Error: Unable to resolve reference $eslint

I’m on node 20.18.0, have removed node_modules and ran npm install.

Installing does succeed after changing it to "eslint": "^9.14.0", as per this comment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a dev build then presents an error in next.js:

Hydration failed because the server rendered HTML didn't match the client. As a result this tree will be regenerated on the client. This can happen if a SSR-ed Client Component used

But that could be one of my browser extensions: it doesn’t occur in a private window.

Comment on lines +28 to +29
'proprietary/react-icons',
'packages/react/unstyled',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are not in this repository – the config was probably copied from the design-system repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants