Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug / Set default signing key for Account Op only if there are accountKeyStoreKeys #529

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Bug / Set default signing key for Account Op only if there are accountKeyStoreKeys #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/controllers/signAccountOp/signAccountOp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ export class SignAccountOpController extends EventEmitter {
// Otherwise, if we don't have a default value, then `this.readyToSign` will always be false unless we set a signer.
// In that case, on the application, we want the "Sign" button to be clickable/enabled,
// and we have to check and expose the `SignAccountOp` controller's inner state to make this check possible.
if (!this.accountOp.signingKeyAddr || !this.accountOp.signingKeyType) {
if (
this.accountKeyStoreKeys.length &&
(!this.accountOp.signingKeyAddr || !this.accountOp.signingKeyType)
) {
this.accountOp.signingKeyAddr = this.accountKeyStoreKeys[0].addr
this.accountOp.signingKeyType = this.accountKeyStoreKeys[0].type
}
Expand Down