Optimization / Make DefiPositionsController State Private in MainController #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngified state from being sent to the frontend, improving performance
PetromirDev
requested changes
Nov 15, 2024
Comment on lines
+131
to
+133
| this.#debounceFunctionCallsOnSameTick('updateDefiPositionsBanners', () => | ||
| this.#updateDefiPositionsBanners() | ||
| ) |
There was a problem hiding this comment.
Call it in #updateSelectedAccountDefiPositions as it only depends on them
PetromirDev
requested changes
Nov 15, 2024
| }) | ||
|
|
||
| return errorBanners | ||
| getDefiPostionsState(accountAddr: string) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By keeping the defiPositions state private and not sending it to the FE, we ensure optimal performance even with multiple heavy accounts added to the wallet