Add filename metadata to multidimdataloader #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2024 10:03
smishra3
approved these changes
Oct 18, 2024
pgarrison
approved these changes
Oct 18, 2024
| @@ -28,17 +28,17 @@ trainer: | |||
|
|
|||
| model: | |||
| compile: True | |||
| #save_dir: /allen/aics/assay-dev/users/Suraj/EMT_Work/image_analysis_test/EMT_image_analysis/Colony_mask_training_inference/eval_whole_movie_multiscale_patch1_zarr_aws | |||
| save_dir: /allen/aics/assay-dev/users/Suraj/EMT_Work/image_analysis_test/EMT_image_analysis/Colony_mask_training_inference/eval_whole_movie_multiscale_patch1_zarr_aws | |||
There was a problem hiding this comment.
If any configs use an /allen path, then the instructions need to tell people to edit it. Instead, I recommend using relative paths (starting with ./) for portability. I've filed an issue to track this going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
filename_or_objmetadata when creating the data loader. This is necessary to generate io maps forMultiTaskIm2Im.Testing:
Successfully ran
python cyto_dl.eval.py experiment=local-eval_scale1_newwith save_dir changed to my local directory. Saved a prediction for each timepoint