-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial new API #361
Initial new API #361
Conversation
…in_overrides Move overrides to top-level config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
@yrkim98 @hughes036 bumping this, once it's reviewed I can incorporate all of our recent fixed into main. |
tags: ["dev"] | ||
seed: 12345 | ||
|
||
experiment_name: YOUR_EXP_NAME | ||
run_name: YOUR_RUN_NAME | ||
ckpt_path: null # must override for prediction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should ckpt_path value be MUST_OVERRIDE ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ckpt_path
is not necessary for training, so I didn't want to use the MUST_OVERRIDE convention here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the comment makes sense then.
What does this PR do?
This PR creates the groundwork for the new API. Note that this is definitely still a draft, and I'm mainly making this PR to get some feedback and ideas. The main principles I followed in creating the new API are below:
train
andpredict
methods will take as arguments all of the config items which are not reasonable to set a default for (e.g. checkpoint path)So, as an example use of the new API, we would have something like:
Before submitting
pytest
command?pre-commit run -a
command?Did you have fun?
Make sure you had fun coding 🙃