Fix issue #20 #23
Merged
Fix issue #20 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyed-dev
reviewed
Oct 31, 2023
aggify/aggify.py
Outdated
|
|
||
| from aggify.compiler import F, Match, Q, Operators # noqa keep | ||
| from aggify.exceptions import ( | ||
| AggifyValueError, | ||
| AnnotationError, | ||
| InvalidField, | ||
| InvalidEmbeddedField, | ||
| OutStageError, | ||
| OutStageError, InvalidArgument, |
seyed-dev
reviewed
Oct 31, 2023
aggify/aggify.py
Outdated
| ) | ||
| from aggify.types import QueryParams | ||
| from aggify.utilty import ( | ||
| to_mongo_positive_index, | ||
| check_fields_exist, | ||
| replace_values_recursive, | ||
| convert_match_query, | ||
| convert_match_query, check_field_exists, get_db_field, |
seyed-dev
reviewed
Oct 31, 2023
aggify/aggify.py
Outdated
| or issubclass(join_field.document_type, EmbeddedDocument) | ||
| or len(split_query) == 1 | ||
| or (len(split_query) == 2 and split_query[1] in Operators.ALL_OPERATORS) | ||
| isinstance(join_field, TopLevelDocumentMetaclass) |
There was a problem hiding this comment.
add comment and description about what do this code
seyed-dev
reviewed
Oct 31, 2023
aggify/aggify.py
Outdated
| from_collection_name = from_collection._meta.get("collection") # noqa | ||
|
|
||
| if not let and not (local_field and foreign_field): | ||
| raise InvalidArgument(expected_list=[['local_field', 'foreign_field'], 'let']) |
seyed-dev
reviewed
Oct 31, 2023
| return self.base_model is not None and isinstance( | ||
| self.base_model._fields.get(field), # type: ignore # noqa | ||
| EmbeddedDocumentField, | ||
| return self.base_model is not None and ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.