#[derive(Display) for NmeaSentence
#64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <[email protected]>
Codecov ReportBase: 78.54% // Head: 79.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 78.54% 79.22% +0.67%
==========================================
Files 21 22 +1
Lines 797 823 +26
==========================================
+ Hits 626 652 +26
Misses 171 171
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
elpiel
commented
Nov 2, 2022
| @@ -30,6 +31,8 @@ use crate::{sentences::*, Error, SentenceType}; | |||
| pub const SENTENCE_MAX_LEN: usize = 102; | |||
|
|
|||
| /// A known and parsable Nmea sentence type. | |||
| #[derive(Display)] | |||
| #[display("${talker_id},{message_id},{data}*{checksum}")] | |||
There was a problem hiding this comment.
The prefix for the sentence start is different for AIS messages!
- Support multiple prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.