Initialize APA #119
Closed
Initialize APA #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
requested changes
Feb 12, 2024
There was a problem hiding this comment.
In general, pretty good PR! Thank you for your contribution.
There are a few minor things I found and the use of enums over bool/char would be ideal.
We should make a good examples with one of the other sentences to follow when developing a new one. Not all impls are in sync let alone the documentation so we should have a better guidance and an example to follow
src/sentences/apa.rs
Outdated
Comment on lines
26
to
39
| // Field Number: | ||
|
|
||
| // 1. Status, BOOLEAN, V = Loran-C Blink or SNR warning A = general warning flag or other navigation systems when a reliable fix is not available | ||
| // 2. Status, BOOLEAN, V = Loran-C Cycle Lock warning flag A = OK or not used | ||
| // 3. Cross Track Error Magnitude | ||
| // 4. Status, BOOLEAN, L = Left or R = Right | ||
| // 5. Cross Track Units, N = Nautical miles or K = Kilometers | ||
| // 6. Status, BOOLEAN, A = Arrival Circle Entered, V = Not Entered | ||
| // 7. Status, BOOLEAN, A = Perpendicular passed at waypoint, V = Not Passed | ||
| // 8. Bearing origin to destination | ||
| // 9. M = Magnetic, T = True | ||
| // 10. Destination Waypoint ID | ||
| // 11. Checksum | ||
| // |
There was a problem hiding this comment.
Suggested change
| // Field Number: | |
| // 1. Status, BOOLEAN, V = Loran-C Blink or SNR warning A = general warning flag or other navigation systems when a reliable fix is not available | |
| // 2. Status, BOOLEAN, V = Loran-C Cycle Lock warning flag A = OK or not used | |
| // 3. Cross Track Error Magnitude | |
| // 4. Status, BOOLEAN, L = Left or R = Right | |
| // 5. Cross Track Units, N = Nautical miles or K = Kilometers | |
| // 6. Status, BOOLEAN, A = Arrival Circle Entered, V = Not Entered | |
| // 7. Status, BOOLEAN, A = Perpendicular passed at waypoint, V = Not Passed | |
| // 8. Bearing origin to destination | |
| // 9. M = Magnetic, T = True | |
| // 10. Destination Waypoint ID | |
| // 11. Checksum | |
| // | |
| /// Field Number: | |
| /// | |
| /// 1. Status, BOOLEAN, V = Loran-C Blink or SNR warning A = general warning flag or other navigation systems when a reliable fix is not available | |
| /// 2. Status, BOOLEAN, V = Loran-C Cycle Lock warning flag A = OK or not used | |
| /// 3. Cross Track Error Magnitude | |
| /// 4. Status, BOOLEAN, L = Left or R = Right | |
| /// 5. Cross Track Units, N = Nautical miles or K = Kilometers | |
| /// 6. Status, BOOLEAN, A = Arrival Circle Entered, V = Not Entered | |
| /// 7. Status, BOOLEAN, A = Perpendicular passed at waypoint, V = Not Passed | |
| /// 8. Bearing origin to destination | |
| /// 9. M = Magnetic, T = True | |
| /// 10. Destination Waypoint ID | |
| /// 11. Checksum | |
| /// |
| @@ -26,7 +26,7 @@ use crate::{parse::NmeaSentence, sentences::utils::array_string, Error, Sentence | |||
| /// 1. Status, BOOLEAN, A = Arrival circle entered, V = not passed | |||
| /// 2. Status, BOOLEAN, A = perpendicular passed at waypoint, V = not passed | |||
| /// 3. Arrival circle radius | |||
| /// 4. Units of radiuos, nautical miles | |||
src/sentences/apa.rs
Outdated
| // 6. Status, BOOLEAN, A = Arrival Circle Entered, V = Not Entered | ||
| // 7. Status, BOOLEAN, A = Perpendicular passed at waypoint, V = Not Passed | ||
| // 8. Bearing origin to destination | ||
| // 9. M = Magnetic, T = True |
There was a problem hiding this comment.
Same goes for Magnetic/True. Seems a better fit for an enum instead.
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
|
Signed-off-by: Lachezar Lechev <[email protected]>
chore: Cargo - upgrade dependencies
Co-authored-by: Lachezar Lechev <[email protected]>
Co-authored-by: Lachezar Lechev <[email protected]>
Co-authored-by: Lachezar Lechev <[email protected]>
Co-authored-by: Lachezar Lechev <[email protected]>
Co-authored-by: Lachezar Lechev <[email protected]>
Co-authored-by: Lachezar Lechev <[email protected]>
|
@elpiel Updated this PR with the fixes and suggestions! Let me know what you think. Thanks so much! |
This was referenced May 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.