Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support defmt #92

Closed
Tracked by #100
PegasisForever opened this issue May 10, 2023 · 3 comments · Fixed by #114
Closed
Tracked by #100

Support defmt #92

PegasisForever opened this issue May 10, 2023 · 3 comments · Fixed by #114
Labels
good first issue
Milestone
v0.7

Comments

@PegasisForever
Copy link

defmt is a high performance logging framework extensively used in embedded rust. It would be great if we can add a feature flag to implement defmt::Format for the Error struct and the Nmea struct.
@elpiel
Copy link
Member

elpiel commented May 10, 2023

Yes, please!
It's a new feature that would be greatly improve no_std.

We're welcoming PRs

@elpiel elpiel added this to the v0.6 milestone Jun 12, 2023
@elpiel
Copy link
Member

elpiel commented Jun 12, 2023 •
edited
Loading

Added for next release - v0.6 0.7
We should also consider other serialization derives (like bincode, serde, etc.).
Edit: Serde support was added in #102

@elpiel elpiel mentioned this issue Jun 12, 2023
Open
5 tasks
@elpiel elpiel mentioned this issue Jan 25, 2024
Merged
@elpiel
Copy link
Member

elpiel commented Feb 13, 2024

@PegasisForever feature is now on main

@elpiel elpiel mentioned this issue Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
v0.7
Development

Successfully merging a pull request may close this issue.

Feat/defmt AeroRust/nmea
2 participants
@elpiel @PegasisForever