-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accelerate -Cadence #4
base: master
Are you sure you want to change the base?
Conversation
.headerLink { | ||
text-decoration: none; | ||
font-size: 200%; | ||
color:#8a4016 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color:#8a4016 | |
color:#8a4016; |
color: #8a4016; | ||
} | ||
|
||
@media only screen and (min-width: 768px){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that you made the page responsive ! People may be looking at your portfolio on any kind of device! Here is a great resource for media queries !
.characteristics{ | ||
display:flex; | ||
flex-direction: column; | ||
/* float:right; */ | ||
margin-right: 5%; | ||
|
||
|
||
} | ||
|
||
.characteristics{ | ||
font-size: 50px; | ||
justify-content: space-between; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are referencing the same element and can be combined.
<p> | ||
I love to living in San Francisco Bay Area, it locates in West Coast and I can view the beautiful Pacific Ocean. | ||
I often go hiking on weekend to see the big ocean and relax myself. I often visit Mori Point Hiking Trail, | ||
it has a very goo good view of Sunset. I can see a clear view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few grammar suggestions for you.
<p> | |
I love to living in San Francisco Bay Area, it locates in West Coast and I can view the beautiful Pacific Ocean. | |
I often go hiking on weekend to see the big ocean and relax myself. I often visit Mori Point Hiking Trail, | |
it has a very goo good view of Sunset. I can see a clear view. | |
<p> | |
I love to live in San Francisco Bay Area, it's located on the West Coast and I can view the beautiful Pacific Ocean. | |
I often go hiking on the weekend to see the big ocean and relax. I often visit Mori Point Hiking Trail, | |
it has a very good view of Sunset. I can see a clear view. |
<p>Hi, my name is Cadence</p> | ||
<h1>I Build What People Need</h1> | ||
<p>I care about what helps people.</p> | ||
<p> I focus on what people need and build applications that empower and impact people's life</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love these short statements. They are concise and clear.
<p class=characteristic>Love<span> what you do</span></p> | ||
<p class=characteristic>Care<span> what impact to people life</span></p> | ||
<p class=characteristic>Focus<span> what your motivation</span></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you have quotation marks around the class attribute. Also, the parent element would normally have a different class name than the child elements.
<p class=characteristic>Love<span> what you do</span></p> | |
<p class=characteristic>Care<span> what impact to people life</span></p> | |
<p class=characteristic>Focus<span> what your motivation</span></p> | |
<p class="characteristic">Love<span> what you do</span></p> | |
<p class="characteristic">Care<span> what impact to people life</span></p> | |
<p class="characteristic">Focus<span> what your motivation</span></p> |
<section> | ||
<h1> Build Web Applications to Mobile Applications</h1> | ||
<div class="viewing-party"> | ||
<h2>Swap meet</h2> | ||
<p>Swap meet is built to allow each person to swap one of their things with anther person's things</p> | ||
<a href="https://github.com/cadence09/task-list-api">Swap Meet</a> | ||
<p>Techs skills: Python</p> | ||
</div> | ||
<div class="task-api"> | ||
<h2>Task List Api</h2> | ||
<p>Task List Api is built to allow users to organze tasks. Users can create, see, update, and delete task.</p> | ||
<a href="https://github.com/cadence09/task-list-api">Task API</a> | ||
<p>Techs skills: Python, Postgres, Flask, Slack API </p> | ||
</div> | ||
|
||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep adding your projects! You have been working on great things!
<a class="headerLink" href="index.html">Home</a> | ||
<a class="headerLink" href="about.html">About</a> | ||
<a class="headerLink" href="portfolio.html">Portfolio</a> | ||
<a class="headerLink" href="hobby.html">Hobby</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use jquery to make your nav bar reusable on each html page. Here is an example your nav info would be stored in nav.html and then a few lines of code would be added to each html file.
I enjoyed the layout and color scheme of your portfolio. It was clean, clear, and concise. I left some comments on how to make your header reusable, grammar, and cleaning up CSS. Great Job, Cadence ! |
No description provided.