Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/28 add assert body methods #32

Merged
merged 9 commits into from
Nov 8, 2023
Merged

Feature/28 add assert body methods #32

merged 9 commits into from
Nov 8, 2023

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Nov 7, 2023 •
edited
Loading

  • Implemented new assert methods.
  • Update of README.md file to describe supported methods of Response Actions.
  • Refactoring suite Actions to Action - design change to fix non sense plural.
  • Implemented unit tests for methods.
  • Implemented Integration test for most of method using Spring pet clinic rest project.

Closes #28

@miroslavpojer miroslavpojer self-assigned this Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

JaCoCo code coverage report - ScAPI

File Coverage [86.2%] 🍏
SuiteTestScenario.scala 100% 🍏
Method.scala 100% 🍏
ExtractJsonResponseActionType.scala 100% 🍏
ResponseActionGroupType.scala 100% 🍏
AssertResponseActionType.scala 100% 🍏
LogResponseActionType.scala 100% 🍏
SuiteRunner.scala 94.34% 🍏
ExtractJsonResponseAction.scala 93.48% 🍏
SuiteFactory.scala 84.67% 🍏
AssertionResponseAction.scala 83.29% 🍏
Total Project Coverage 87.34% 🍏

dk1844
dk1844 reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments...

README.md Show resolved Hide resolved
.../src/main/scala/africa/absa/testing/scapi/rest/response/action/AssertionResponseAction.scala Outdated Show resolved Hide resolved
.../src/main/scala/africa/absa/testing/scapi/rest/response/action/AssertionResponseAction.scala Outdated Show resolved Hide resolved
.../src/main/scala/africa/absa/testing/scapi/rest/response/action/AssertionResponseAction.scala Outdated Show resolved Hide resolved
...in/scala/africa/absa/testing/scapi/rest/response/action/types/AssertResponseActionType.scala Outdated Show resolved Hide resolved
testApi/src/test/resources/test_project/localhost.env.json Show resolved Hide resolved
testApi/src/test/resources/test_project/localhost.env.json Show resolved Hide resolved
testApi/src/test/resources/test_project/suites/demo/getOwners.after.json Show resolved Hide resolved
testApi/src/test/resources/test_project/suites/demo/getOwners.before.json Show resolved Hide resolved
@miroslavpojer miroslavpojer merged commit 34688f1 into master Nov 8, 2023
2 checks passed
@miroslavpojer miroslavpojer deleted the feature/28_add_assert_body_methods branch November 8, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk1844 dk1844 dk1844 approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement method ideas #2 - assert body methods
2 participants
@miroslavpojer @dk1844