-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive layout #70
base: master
Are you sure you want to change the base?
Conversation
@edoardocavazza it's great to me! Only one thing: it's possible to add a bigger padding on the left on each page? Something that will make the whole content not so sticky to the left margin. For the rest, it scales great. |
I have aligned the branch to latest modifies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edoardocavazza Definitely looks better for responsive. I don't think the back anchor component will work when it gets merged to master. If we keep what you implemented and hardcore /studio/
in front to fix for prod, then it won't work for local dev, and vice versa. I wish I knew a better way to handle it.
@@ -48,7 +48,7 @@ | |||
<page-header assetsUrl="../../assets"></page-header> | |||
|
|||
<div class="pages-content"> | |||
<back-anchor assetsUrl="../../assets"></back-anchor> | |||
<back-anchor href="/" assetsUrl="../../assets"></back-anchor> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The works for local dev, but unfortunately, it doesn't work for the prod. The reason is because the root URL on prod is https://github.com/AR-js-org/studio
@thauska hi :) still actual ? |
I can see it today |
Issue: #62
Extra: