Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CMake: Tarball Support #378

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 9, 2024

This speeds up the configure step from 20.1sec to 6.5sec by just downloading a shallow copy of AMReX & pybind11.

  • check AMReX version output during configure and ensure build version logic in AMReX is still sensible (e.g., output during AMReX initialize)
  • add a script to simply update tar sha and git branch at the same time for AMReX & pybind11 updates.

@ax3l ax3l added install Build and installation Performance optimization labels Oct 9, 2024
@ax3l
Copy link
Member Author

ax3l commented Oct 9, 2024

@EZoni @WeiqunZhang this PR is not urgent and I can take it on when I am back from parental leave. I want to introduce it consistently in pyAMReX/WarpX/ImpactX/HiPACE during the same release cycle. Can wait for 2025.

I already use the same trick in openPMD-api 0.16.0+
As an alternative approach, one could do shallow (--depth 1) git clones, but unfortunately, the CMake git fetcher does not support shallow copies.

@ax3l ax3l requested a review from EZoni October 9, 2024 18:59
@ax3l ax3l changed the title [WIP] CMake: Tarball Suppport [WIP] CMake: Tarball Support Oct 9, 2024
This speeds up the configure step from 20.1sec to 6.5sec by just
downloading a shallow copy of AMReX & pybind11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant