Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more consistency checks #84

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

marcofavorito
Copy link
Member

Proposed changes

Improve consistency check of PDDL domains and problems instances.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

@marcofavorito marcofavorito changed the title Consistency checks Add more consistency checks Jun 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #84 (6ba0257) into main (f54e187) will increase coverage by 0.26%.
The diff coverage is 94.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   90.78%   91.05%   +0.26%     
==========================================
  Files          24       31       +7     
  Lines        1389     1542     +153     
  Branches      245      265      +20     
==========================================
+ Hits         1261     1404     +143     
- Misses         93      101       +8     
- Partials       35       37       +2     
Flag Coverage Δ
unittests 91.05% <94.59%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pddl/definitions/base.py 85.71% <85.71%> (ø)
pddl/validation/base.py 90.47% <90.47%> (ø)
pddl/definitions/predicates_def.py 92.00% <92.00%> (ø)
pddl/_validation.py 91.48% <100.00%> (-0.58%) ⬇️
pddl/core.py 92.18% <100.00%> (+0.06%) ⬆️
pddl/definitions/__init__.py 100.00% <100.00%> (ø)
pddl/definitions/constants_def.py 100.00% <100.00%> (ø)
pddl/formatter.py 95.89% <100.00%> (ø)
pddl/helpers/base.py 97.72% <100.00%> (+0.32%) ⬆️
pddl/logic/predicates.py 94.94% <100.00%> (+0.38%) ⬆️
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants