Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ml-traffic-sign-training #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ml-traffic-sign-training #28

wants to merge 1 commit into from

Conversation

mpdmanash
Copy link

Machine Learning codes in python to train a three layer neural network
and two methods of TensorFlow library on German traffic sign dataset.

Machine Learning codes in python to train a three layer neural network
and two methods of TensorFlow library on German traffic sign dataset.
@krishna95
Copy link
Contributor

@ManashRaja, Good Work on the models. Couple of things. The code for the tensorflow1.py does not compile. Also send a link for the dataset and try to incorporate it in the code itself. Also change the names of tensorflow1.py and tensorflow2.py to appropriate names.
@abinashmeher999 Can you please look at the PR and suggest changes.
@kumarkrishna Can you please comment on the tensorflow2.py which involves the training using Deep MNIST features of tensorflow. I consider it to be heavily overfitted.

# Author: Manash Pratim Das ([email protected])
########################################################################################

import cv2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this in requirements.txt.

@abinashmeher999
Copy link
Member

Looks good. Nicely done. Please make time to document your functions. It will be a huge help to both you and others who will be referring to this code.

########################################################################################

import cv2
import numpy as N
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one too. I am surprised this wasn't in the requirements till now.

@hargup
Copy link
Member

hargup commented Feb 11, 2016

Some nitpicks,

  • Conventionally we write import numpy as np instead of import numpy as Nsticking to the convention makes things easier and I also suggest that you adapt PEP8 style guide https://www.python.org/dev/peps/pep-0008/
  • In create_processed_dataset.py and create_dataset.py you have used tabs instead of spaces, it will mess things up when someone who uses spaces for indentation will edit the same file. You don't need to press space, you should configure your editor to expand a tab to four space, search around the web you should find how to do it, if you don't come back asking for help.

@mpdmanash
Copy link
Author

Thanks for all the suggestions. I will do the necessary changes and update the PR.
@abinashmeher999 I didn't know about the requirements.txt. Will learn and make the file. Also, shall I include the dataset images? Or should I just provide the download links for them from its original source?

@abinashmeher999
Copy link
Member

@ManashRaja https://pip.pypa.io/en/stable/reference/pip_freeze/ See the 2nd example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants