Replace gamemode with separate settings #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed ACF.Gamemode, ACF.CompFuelRate, and ACF.CompFuelFactor - Added ACF.LegalChecks and associated settings option to replace Sandbox mode behavior - ACF.FuelRate now replaces uses of ACF.CompFuelRate and has had its min/max values changed to 0-30 in order to replace Sandbox and Competitive fuel behaviors - Fuel usage is disabled when ACF.FuelFactor == 0 rather than ACF.Gamemode ~= 1
I realized that there could maybe be issues if you set the fuel factor to 0 and then to something else
Stooberton
reviewed
Sep 15, 2023
|
Quality work 👍 Besides upping the default consumption to 27.8 I've got no issues with this. |
Also set the FuelFactor max back to 2 to account for the change and removed the duplicate FuelRate multipliers in engine efficiency
Noticed this while working on this PR. Every setting that did not have a callback message now has one, and the existing ones now have a bit better phrasing. Also changed the GunsCanSmoke text to not trail out of the spawnmenu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfills #243
I'm not sure if it would be ideal to keep the dropdown gamemode menu (to use as presets for the new settings) and/or a separate multiplier for the Competitive fuel consumption (as a checkbox probably?), but these can be added back if desired.
Radar behavior will also need to be changed to account for this PR (
maybe moved to use the RestrictInfo setting instead or something?Done in ACF-Team/ACF-3-Missiles#88 )