-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests/clean fix_level_coord()
#90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only change is the fix_level_coord
docstring, while the other two are questions about the clarity for the tests and so aren't completely necessary.
Clean test body so assertions match coord() calls.
I've refactored the tests with fixtures, now the assertions test against a @blimlim How do you find the readability of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and clearer to read!
Closes #53. Note, this PR is merges to
main
.This PR:
fix_level_coord()
process()
)These tests use
iris
coordinate objects to avoid mocks cube attributes. Based on this experiment, this could be a reasonable approach for other tests requiringiris
coordinates.Any comments welcome!