Refactor 32 bit overflow testing.

ACCESS-NRI · Oct 8, 2024 · 08bbca4 · 08bbca4
1 parent 951e03d
commit 08bbca4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/test/test_um2netcdf.py b/test/test_um2netcdf.py
@@ -1084,6 +1084,9 @@ def test_convert_32_bit_safe(ua_plev_cube):
                           ([-3000000000], operator.lt, np.iinfo(np.int32).min)])
 def test_convert_32_bit_overflow_warning(ua_plev_cube, array, _operator, bound):
     # ensure overflow covered for large positive & negative int64s
+    msg = f"Over/underflow impossible with {array[0]} {_operator} {bound}"
+    assert _operator(array[0], bound), msg
+
     ua_plev_cube.data = np.array(array, dtype=np.int64)
 
     with pytest.warns(RuntimeWarning) as record:
@@ -1093,9 +1096,6 @@ def test_convert_32_bit_overflow_warning(ua_plev_cube, array, _operator, bound):
             msg = f"No overflow warning with {array} {_operator} {bound}"
             pytest.fail(msg)
 
-    if _operator:
-        assert _operator(array[0], bound)
-
     assert ua_plev_cube.data.dtype == np.int32