-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cd to upload to conda #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There seems to be a problem with later versions of python. This string https://github.com/ACCESS-NRI/ncigrafana/blob/master/ncigrafana/UsageDataset.py#L462-L469 when it is formatted in the query here https://github.com/ACCESS-NRI/ncigrafana/blob/master/ncigrafana/UsageDataset.py#L462-L469 ends up looking like this: 'SELECT printf("%s (%s)", Users.fullname, Users.user) as Name, scandate as Date, SUM((\'size\',)) AS totsize \n FROM (\'UserStorage\',)\n LEFT JOIN Users ON (\'UserStorage\',).user_id = Users.id\n WHERE scandate between \'1984-07-01\' AND \'1984-09-30\'\n AND project_id = (1,)\n AND storagepoint_id = (4,)\n GROUP BY Name, Date\n ORDER BY Date' so the formatting has treated all the strings and numbers as arrays. Very odd, but I assume this is something that change in python from v3.8 to 3.9, as the former was fine. We should, in any case, test with much more modern versions (3.11 and 3.12), but I assume they also exhibit the same behaviour. Is that enough to go on with @utkarshgupta95? |
BTW I debugged this by cloning the repo and running
I also added import pdb; pdb.set_trace() In the |
@aidanheerdegen The issue seems to be with pandas >= 2.2.0. After debugging for hours I did the very basic step to print the exception for this line, which gave
The issue is similar to the one below, although it uses SQLAlchemy instead of dataset I cannot find a similar approach for Alternatively I can execute the query with |
No.
That sounds like a good approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for tracking that down that error and fixing it.
Closes #1