Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js files finder #4983

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Js files finder #4983

wants to merge 5 commits into from

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Nov 15, 2024

Refacto of code of lizmap controller to a dedicated class : reusable , testable
Funded by 3liz

@github-actions github-actions bot added this to the 3.10.0 milestone Nov 15, 2024
@nworr nworr added the run end2end If the PR must run end2end tests or not label Nov 15, 2024
);
foreach ($items as $item) {
$jsPathRoot = realpath($repositoryPath.$item.$dir);
if (is_dir($jsPathRoot)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (is_dir($jsPathRoot)) {
if (!is_dir($jsPathRoot)) {

To keep code on the left side of the editor, I find it more convenient negate, and a continue statement, so then all the code under can be pulled left.

Just a suggestion, about code visibility.

@Gustry
Copy link
Member

Gustry commented Nov 15, 2024

Nice addition !
We will add it after in the project page table ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants