Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code #261

Open
2 tasks
flobernd opened this issue Oct 30, 2021 · 3 comments
Open
2 tasks

Reformat code #261

flobernd opened this issue Oct 30, 2021 · 3 comments
Assignees
Labels
C-cleanup Category: Cleanup of code and refactoring work P-low Priority: Low

Comments

@flobernd
Copy link
Member

flobernd commented Oct 30, 2021

  • Get rid of uncommon else indentation
  • Change maximum line length from 100 -> 120 characters (evaluate first)
@flobernd flobernd added the C-cleanup Category: Cleanup of code and refactoring work label Oct 30, 2021
@flobernd flobernd self-assigned this Oct 30, 2021
@athre0z
Copy link
Member

athre0z commented Oct 30, 2021

Change maximum line length from 100 -> 200 characters (evaluate first)

Urgh, please no.

@flobernd
Copy link
Member Author

@athre0z
Sorry, I wrote 200 instead of 120 chars. Still a "no go" from your side?

@athre0z
Copy link
Member

athre0z commented Oct 30, 2021

Hmm, I'd still have to lower font size or change my desktop layout (screen split vertically half terminal, half editor) to make that work. I can fit about 110 characters with my current layout. I'd prefer to stay with 100, but could probably make 120 work via font size if you got a strong opinion on that.

With 120, I feel like it becomes strictly required to differentiate between line length for code and comments, since doc comment blocks look absolutely horrible when stretched to 120. For example, the Rust formatting guide suggests 100 chars for code and 80 chars for comments. Python's PEP8 has a similar rule, IIRC.

I'd suggest to just leave as-is for now.

@athre0z athre0z added the P-low Priority: Low label Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: Cleanup of code and refactoring work P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants