Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edge_data dictionary in the graph data structure #247

Open
RazinShaikh opened this issue Jun 29, 2024 · 3 comments
Open

Support edge_data dictionary in the graph data structure #247

RazinShaikh opened this issue Jun 29, 2024 · 3 comments

Comments

@RazinShaikh
Copy link
Contributor

RazinShaikh commented Jun 29, 2024

This is analogous to vdata and can be used for storing arbitrary data corresponding to an edge. For example, storing edge curve information in ZXLive (see zxcalc/zxlive#270), future support of multiplier edges, etc.

@jvdwetering
Copy link
Collaborator

So it is definitely an option to store it in edge data. But seeing as we now also have Edge objects, it might also just be part of the Edge? Although then it won't be available to GraphS, so that's probably not ideal.

@RazinShaikh
Copy link
Contributor Author

Do you mean store curve distance in the Edge class or an edge data dictionary in the edge class?

@jvdwetering
Copy link
Collaborator

Maybe just edge_data in the Edge class. But for consistency, since there is a vertex_data in the Graph, maybe we should also have a edge_data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants