Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing electron bin folder #53

Open
matejdro opened this issue Nov 13, 2023 · 3 comments
Open

Missing electron bin folder #53

matejdro opened this issue Nov 13, 2023 · 3 comments
Assignees

Comments

@matejdro
Copy link

When downloading settings, I'm getting this error:

image

/usr/lib/electron25 exists, but there is no bin folder. This is on Arch Linux. Electron is normally installed from arch package and as far as I can tell, works fine. Not sure why plugin expects bin folder to be there.

@daiyam
Copy link
Member

daiyam commented Nov 13, 2023

With which AUR have installed VSCode or VSCodium?

The issue must be related to the lookup for the binary to restart the app when the sync is done.

@matejdro
Copy link
Author

It's the default code package, Code - OSS.

@daiyam
Copy link
Member

daiyam commented Nov 13, 2023

Yeah, the cli path is modified to "$pkgdir"/usr/bin/code-oss (https://gitlab.archlinux.org/archlinux/packaging/packages/code/-/blob/main/PKGBUILD?ref_type=heads#L127, https://gitlab.archlinux.org/archlinux/packaging/packages/code/-/blob/main/clipath.patch?ref_type=heads)

While the extension uses the current process to guess the app executable (https://github.com/zokugun/vscode-sync-settings/blob/master/src/utils/restart-app.ts#L70)

And since the Code - OSS use the system Electron to launch, the detection would need to be updated to support that version.

@daiyam daiyam self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants